Messages in this thread | | | Date | Thu, 25 Jul 2013 03:47:32 +0200 | From | Hannes Frederic Sowa <> | Subject | Re: [RFC PATCH - diffstat only] include/net: Remove extern from function prototypes |
| |
On Wed, Jul 24, 2013 at 06:41:20PM -0700, Joe Perches wrote: > On Thu, 2013-07-25 at 01:27 +0000, Cong Wang wrote: > > On Tue, 23 Jul 2013 at 17:58 GMT, Joe Perches <joe@perches.com> wrote: > > You dropped the author from the cc list. > Always reply to the author. > > > > Function prototypes don't need to be declared > > > extern in .h files. It's assumed by the compiler > > > and is as unnecessary as using auto is when > > > declaring automatic/local variables in a block. > > > > > Since we all know this, why bother it? > > If everyone knew this, new ones wouldn't be added. > But a lot are.
Couldn't checkpatch take care of these?
Greetings,
Hannes
| |