lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/2] Drivers: hv: balloon: Online the hot-added memory "in context"
Date


> -----Original Message-----
> From: Dave Hansen [mailto:dave@sr71.net]
> Sent: Wednesday, July 24, 2013 5:04 PM
> To: KY Srinivasan
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> andi@firstfloor.org; akpm@linux-foundation.org; linux-mm@kvack.org;
> kamezawa.hiroyuki@gmail.com; mhocko@suse.cz; hannes@cmpxchg.org;
> yinghan@google.com
> Subject: Re: [PATCH 2/2] Drivers: hv: balloon: Online the hot-added memory "in
> context"
>
> On 07/24/2013 02:29 PM, K. Y. Srinivasan wrote:
> > /*
> > - * Wait for the memory block to be onlined.
> > - * Since the hot add has succeeded, it is ok to
> > - * proceed even if the pages in the hot added region
> > - * have not been "onlined" within the allowed time.
> > + * Before proceeding to hot add the next segment,
> > + * online the segment that has been hot added.
> > */
> > - wait_for_completion_timeout(&dm_device.ol_waitevent,
> 5*HZ);
> > + online_memory_block(start_pfn);
>
> Ahhhhh.... You've got a timeout in the code in order to tell the
> hypervisor that you were successfully able to add the memory? The
> userspace addition code probably wasn't running within this timeout
> period. right?

As I have always said, the onlining would not occur within a specified amount
of time (under some conditions). The timeout here is to ensure that we are able
to online the memory before attempting to hot-add more memory. With the ability
to online memory from within the kernel, we don't need this timeout and the code is
much more predictable.

Regards,

K. Y





\
 
 \ /
  Last update: 2013-07-25 03:41    [W:5.121 / U:0.020 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site