lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: trans_rdma: remove unused function
From
From: Paul Bolle <pebolle@tiscali.nl>
Date: Thu, 25 Jul 2013 01:09:47 +0200

> On Wed, 2013-07-24 at 15:46 -0700, David Miller wrote:
>> From: Andi Shyti <andi@etezian.org>
>> > This patch gets rid of the following warning:
>> >
>> > net/9p/trans_rdma.c:594:12: warning: ‘rdma_cancelled’ defined but not used [-Wunused-function]
>> > static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req)
>> >
>> > The rdma_cancelled function is not called anywhere in the kernel
>> >
>> > Signed-off-by: Andi Shyti <andi@etezian.org>
>>
>> Applied to net-next, thanks.
>
> After this patch one might as well revert the rest of commit
> 80b45261a0b2 ("9P: Add cancelled() to the transport functions.") too. It
> seems the entire cancelled callback stuff is now pointless.
>
> As I already asked in https://lkml.org/lkml/2013/7/15/87 : did that
> commit "forget to actually hook up rdma_cancelled() into
> p9_rdma_trans()?". It does look so to me.

If nobody responds to this in the next day or so, feel free to send me
a patch which rips it all out.

No response means they don't care, and neither, therefore, should we.

Thanks.
\
 
 \ /
  Last update: 2013-07-25 02:01    [W:0.054 / U:0.604 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site