lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver
On Thu, Jul 25, 2013 at 12:53:40AM +0300, Dan Carpenter wrote:
> > +static int gdm_lte_ioctl_get_data(struct wm_req_t *req, struct net_device *dev)
> > +{
> > + u16 id = req->data_id;
> > +
> > + switch (id) {
> > + case GET_ENDIAN_INFO:
> > + /* required for the user space application to find out device endian */
> > + get_dev_endian(&req->data, dev);
> > + break;
> > + default:
> > + printk(KERN_ERR "glte: ioctl - unknown type %d\n", id);
> > + break;
> > + }
> > + return 0;
> > +}
>
> This should be a sysfs file not an ioctl. What would break if we
> fixed this right now (as opposed to waiting until we can't change
> the API?).
>
> Otherwise if we can't change this, then it should return an error
> code instead of printing a message.

It should just be removed, why would you care about the endian-ness of
the device at all?

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-07-25 00:41    [W:0.072 / U:1.652 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site