lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] VFS: Prevent core dump with core_pattern set to empty string
Date
If the core_pattern (proc/sys/core_pattern) is set to an empty string
a core dump is still made but to a file with a filename set by an
uninitialized buffer in format_corename(). This patch fixes the use of the
uninitialized buffer and also aborts the core dump with a warning message
when core_pattern is set to an empty string.

Tested and developed against 3.11-rc2

Signed-off-by: Daniel Nilsson <daniel@dnil.se>
---
fs/coredump.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/fs/coredump.c b/fs/coredump.c
index 72f816d..5035402 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -170,6 +170,11 @@ static int format_corename(struct core_name *cn, struct coredump_params *cprm)
if (ispipe)
++pat_ptr;

+ if (*pat_ptr == '\0') {
+ err = cn_printf(cn, "");
+ goto out;
+ }
+
/* Repeat as long as we have more pattern to process and more output
space */
while (*pat_ptr) {
@@ -617,6 +622,13 @@ void do_coredump(siginfo_t *siginfo)
goto fail_unlock;
}

+ if (cn.corename[0] == '\0') {
+ printk(KERN_WARNING
+ "core_pattern contains an empty string!\n");
+ printk(KERN_WARNING "Skipping core dump\n");
+ goto fail_unlock;
+ }
+
cprm.file = filp_open(cn.corename,
O_CREAT | 2 | O_NOFOLLOW | O_LARGEFILE | flag,
0600);
--
1.7.9.5


\
 
 \ /
  Last update: 2013-07-25 00:21    [W:0.036 / U:2.664 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site