lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH-RESEND 3/3] staging/lustre: fix Kconfig bool defaults
On Thu, Jul 25, 2013 at 02:08:19AM +0800, Peng Tao wrote:
> From: Peng Tao <tao.peng@emc.com>
>
> Should be y instead of true.
>
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Cc: Andreas Dilger <andreas.dilger@intel.com>
> Signed-off-by: Peng Tao <tao.peng@emc.com>
> ---
> drivers/staging/lustre/lustre/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
> index 9ae7fa8..e3b3c74 100644
> --- a/drivers/staging/lustre/lustre/Kconfig
> +++ b/drivers/staging/lustre/lustre/Kconfig
> @@ -52,4 +52,4 @@ config LUSTRE_DEBUG_EXPENSIVE_CHECK
> config LUSTRE_TRANSLATE_ERRNOS
> bool
> depends on LUSTRE_FS && !X86
> - default true
> + default y

Why is the default for this going to be 'y'? That should only be for
things that keep the machine from booting.

If this is something you always want to do, then why make it an option
at all?

Given that there is no documentation for what this option is, and why
people should always turn it on, I can't accept this patch, sorry.

greg k-h


\
 
 \ /
  Last update: 2013-07-24 22:41    [W:0.053 / U:1.380 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site