lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: palmas: fix pdata ptr not be updated after it has been allocated
On 7/24/2013 1:02 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Wed, Jul 24, 2013 at 12:28:02PM -0400, Rhyland Klein wrote:
>
>> + /* Store the pdata pointer after everything else passes */
>> + pdev->dev.platform_data = pdata;
>
> No, this is bad - the driver should not be modifying the platform_data
> pointer, it's owned by the thing that created the device. If the
> platform data needs to be modified it should be copied somewhere in the
> driver data.

Alright, thanks.

-rhyland

>
> * Unknown Key
> * 0x7EA229BD
>


--
nvpublic


\
 
 \ /
  Last update: 2013-07-24 19:21    [W:0.037 / U:1.604 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site