lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] x86/mce: Pay no attention to 'F' bit in MCACOD when parsing 'UC' errors.
Date
> How about just changing MCACOD to 0xefff? I don't think we ever care
> about the 'F' bit, so we could simplify this by just changing MCACOD.

That certainly reduces the size of the patch ... I was a little worried about
just changing this because it doesn't match the definition of the MCACOD
field in the SDM (Figure 15-5 in 15.3.2.2 IA32_MCi_STATUS MSRS).

But auditing the existing uses of this define - we only currently use it in
places where we are looking for specific recoverable error signatures.
So I think a big comment in mce.h explaining the missing 'F' bit should
suffice.

I'm going to take Chen Gong's suggestion and break this into two patches,
one to fix the regression from the earlier cleanup. Another to tackle the
"F" bit issue.

New patches in a while.

-Tony


\
 
 \ /
  Last update: 2013-07-24 19:21    [W:0.057 / U:3.552 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site