Messages in this thread | | | Date | Wed, 24 Jul 2013 15:14:12 +0900 | From | Chanwoo Choi <> | Subject | Re: [PATCH 1/3 v6] cpufreq: Add debugfs directory for cpufreq |
| |
Hi Viresh,
>>> + if (!policy->cpu_debugfs[idx]) { >>> + pr_err("creating debugfs directory failed\n"); >>> + return -ENODEV; >>> + } >>> + >>> + return 0; >>> +} >>> + >>> +static int cpufreq_create_debugfs_symlink(struct cpufreq_policy *policy, >>> + unsigned int src_cpu, >>> + unsigned int dest_cpu) >> >> Only use policy and cpu for which symlink has to be created as param >> to this routine. And create link to policy->cpu. >> > > OK, I'll simplify function prototype(cpufreq_create_debugfs_symlink) by removing > unnecessary parameter. >
I considered the parameter type of cpufreq_create_debugfs_symlink() and then I need following function declaration because this function didn't always need to create symbolic link to policy->cpu. This function declaration is capable of creating symbolic link as 'dest_cpu -> src_cpu'
+static int cpufreq_create_debugfs_symlink(unsigned int src_cpu, + unsigned int dest_cpu)
Thanks, Chanwoo Choi
| |