lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] tuntap: hardware vlan tx support
On Wed, 24 Jul 2013 13:55:14 +0800
Jason Wang <jasowang@redhat.com> wrote:

> On 07/23/2013 11:53 PM, Stephen Hemminger wrote:
> > On Tue, 23 Jul 2013 15:15:48 +0800
> > Jason Wang <jasowang@redhat.com> wrote:
> >
> >> + struct {
> >> + __be16 h_vlan_proto;
> >> + __be16 h_vlan_TCI;
> >> + } veth;
> > Don't you want to use struct vlan_hdr here?
>
> There's no need to care encapsulated proto here. In fact, we just
> emulate the hardware inserting of 802.1Q header. So only skb->vlan_tci
> and skb->vlan_proto needs to be cared.
> > Your definition puts the two fields out of order?
>
> It's order is same as struct vlan_ethhdr. Did you see any issue?

I was looking at if_vlan.h struct vlan_hdr. The veth structure
is a slice between ether and vlan header.


\
 
 \ /
  Last update: 2013-07-24 17:41    [W:0.046 / U:2.456 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site