lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 02/48] staging/lustre/obdclass: restore lu_ref
On Wed, Jul 24, 2013 at 4:52 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Jul 23, 2013 at 08:31:15PM +0000, Dilger, Andreas wrote:
>> On 2013/07/23 1:37 PM, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
>> wrote:
>>
>> >On Tue, Jul 23, 2013 at 12:06:23AM +0800, Peng Tao wrote:
>> >> lu_ref.[ch] were mistakenly removed by coan2. Add them back and guard
>> >> with CONFIG_LUSTRE_DEBUG_LU_REF_CHECK.
>> >
>> >Ick, why? Why not use the in-kernel infrastructure for this type of
>> >thig, _iff_ you really need it.
>> >
>> >Why do you need this at all, isn't the reference code fully debugged by
>> >now, given that this has been running for years? I would only expect to
>> >see something like this in new code that is still being developed.
>>
>> Lustre is still being developed, so it is useful to be able to enable this
>> debugging to catch any new problems that are introduced.
>
> Ok, then use the in-kernel infrastructure for this type of thing, don't
> roll your own and add custom stuff that will later just have to be
> ripped out and converted to use the in-kernel stuff.
>
OK. Will drop this one.

Thanks,
Tao


\
 
 \ /
  Last update: 2013-07-24 08:41    [W:0.099 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site