lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V8 13/15] perf tools: expand perf_event__synthesize_sample()
On Wed, Jul 24, 2013 at 04:15:20PM +0300, Adrian Hunter wrote:

SNIP

> >> + }
> >> +
> >> + if (type & PERF_SAMPLE_REGS_USER) {
> >> + if (sample->user_regs.regs && sample_regs_user) {
> >> + *array++ = sample_regs_user;
> >
> > it's 'enum perf_sample_regs_abi' value that goes here ^^^
> >
> > I guess for now it could be hardcoded like:
> >
> > #if defined(__x86_64__)
> > abi = PERF_SAMPLE_REGS_ABI_64
> > #else
> > #if defined(__i386__)
> > abi = PERF_SAMPLE_REGS_ABI_64

ugh, PERF_SAMPLE_REGS_ABI_32 ^^^ of course ;-)

> > #endif
> > WARN()
> > #endif
>
> Thanks for reviewing this.
>
> Why isn't it better to leave it as a parameter?

np, you could have it as parameter.. but I guess for now
you'll endup with above code in the upper layer anyway

jirka


\
 
 \ /
  Last update: 2013-07-24 16:01    [W:0.061 / U:2.312 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site