lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/7] usb: phy: msm: Migrate to Managed Device Resource allocation
Hi,

On Tue, Jul 09, 2013 at 06:47:08PM +0300, Ivan T. Ivanov wrote:
> From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
>
> Use managed device resources to clean up the probe/remove
> and get DT support for free.
>
> Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
> ---
> drivers/usb/phy/phy-msm-usb.c | 78 +++++++++++------------------------------
> 1 file changed, 20 insertions(+), 58 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> index ab1b880..cc37f5e 100644
> --- a/drivers/usb/phy/phy-msm-usb.c
> +++ b/drivers/usb/phy/phy-msm-usb.c
> @@ -1458,30 +1455,27 @@ static int __init msm_otg_probe(struct platform_device *pdev)
> * clock is introduced to remove the dependency on AXI
> * bus frequency.
> */
> - motg->core_clk = clk_get(&pdev->dev, "usb_hs_core_clk");
> + motg->core_clk = devm_clk_get(&pdev->dev, "usb_hs_core_clk");
> if (IS_ERR(motg->core_clk))
> motg->core_clk = NULL;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!res) {

no need to check for the resource when using devm_ioremap_resource()

> dev_err(&pdev->dev, "failed to get platform resource mem\n");
> - ret = -ENODEV;
> - goto put_core_clk;
> + return -ENODEV;
> }
>
> - motg->regs = ioremap(res->start, resource_size(res));
> + motg->regs = devm_ioremap_resource(&pdev->dev, res);
> if (!motg->regs) {
> dev_err(&pdev->dev, "ioremap failed\n");

don't print error messages when using devm_ioremap_resource()

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-07-24 15:41    [W:0.340 / U:34.108 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site