lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] x86: introduce hypervisor_cpuid_base()
On 07/24/2013 12:03 AM, H. Peter Anvin wrote:
> On 07/23/2013 04:16 AM, Paolo Bonzini wrote:
>> That's nicer, though strcmp is what the replaced code used to do in
>> patches 2 and 3.
>>
>> Note that memcmp requires the caller to use "KVMKVMKVM\0\0" as the
>> signature (or alternatively hypervisor_cpuid_base can copy the argument
>> into another 12-byte local variable).
>>
> Which is the actual signature, though...
>
> -hpa
>
>

Since it's just a minor optimization. How about just keep using the
strcmp()?


\
 
 \ /
  Last update: 2013-07-24 07:21    [W:0.074 / U:8.496 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site