Messages in this thread | | | Date | Tue, 23 Jul 2013 19:29:13 -0700 | Subject | Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A | From | Grant Grundler <> |
| |
On Tue, Jul 23, 2013 at 4:46 PM, David Miller <davem@davemloft.net> wrote: ... > A quick scan shows that smsc75xx, smsc95xx, and ax88179_178a all have > this problem. > > Instead of the patch starting this thread, I'd like to see one that > hits all three drivers and removes all SG and TSO features bits from > both the ->features _and_ ->hw_features settings.
Since you are asking to remove TSO, do you also want skb_linearize() calls in ax88179_178a.c and smsc75xx.c removed as well?
Not part of the original patch - but based on this thread, Eric seems to think calling skb_linearize isn't necessary or helpful either.
cheers, grant
| |