| Date | Tue, 23 Jul 2013 17:25:48 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 18/21] x86, numa: Synchronize nid info in memblock.reserve with numa_meminfo. |
| |
On Fri, Jul 19, 2013 at 03:59:31PM +0800, Tang Chen wrote: > Vasilis Liaskovitis found that before we parse SRAT and fulfill numa_meminfo, > the nids of all the regions in memblock.reserve[] are MAX_NUMNODES. That is > because nids have not been mapped at that time. > > When we arrange ZONE_MOVABLE in each node later, we need nid in memblock. So > after we parse SRAT and fulfill nume_meminfo, synchronize the nid info to > memblock.reserve[] immediately.
Having a separate sync is rather nasty. Why not let memblock_set_node() and alloc functions set nid on the reserved regions?
Thanks.
-- tejun
|