Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 03/27] drivers/cpuidle: don't check resource with devm_ioremap_resource | Date | Tue, 23 Jul 2013 23:26:55 +0200 |
| |
On Tuesday, July 23, 2013 08:01:36 PM Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Daniel, I'm leaving this one to you.
Thanks, Rafael
> --- > Please apply via the subsystem-tree. > > drivers/cpuidle/cpuidle-kirkwood.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c > index 521b0a7..2237135 100644 > --- a/drivers/cpuidle/cpuidle-kirkwood.c > +++ b/drivers/cpuidle/cpuidle-kirkwood.c > @@ -60,9 +60,6 @@ static int kirkwood_cpuidle_probe(struct platform_device *pdev) > struct resource *res; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (res == NULL) > - return -EINVAL; > - > ddr_operation_base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(ddr_operation_base)) > return PTR_ERR(ddr_operation_base); > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |