Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH 4/4] x86: properly handle kvm emulation of hyperv | Date | Tue, 23 Jul 2013 13:55:17 +0000 |
| |
> -----Original Message----- > From: Jason Wang [mailto:jasowang@redhat.com] > Sent: Tuesday, July 23, 2013 5:41 AM > To: tglx@linutronix.de; mingo@redhat.com; hpa@zytor.com; x86@kernel.org; > gleb@redhat.com; pbonzini@redhat.com; kvm@vger.kernel.org; linux- > kernel@vger.kernel.org > Cc: Jason Wang; KY Srinivasan > Subject: [PATCH 4/4] x86: properly handle kvm emulation of hyperv > > Recent kvm has some basic support of hyperv, this will cause the guest to > identify itself as running on top of hyperv instead of kvm which will disable > kvm pv functionality. This is because we try to detect hyperv before kvm. Solve > this by simply checking kvm in detect_hypervisor() first. >
This strategy of hypervisor detection based on some detection order IMHO is not a robust detection strategy. The current scheme works since the only hypervisor emulated (by other hypervisors happens to be Hyper-V). What if this were to change.
Regards,
K. Y
| |