Messages in this thread | | | Date | Tue, 23 Jul 2013 15:30:57 +0200 | From | Sebastian Hesselbarth <> | Subject | Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage |
| |
On 07/23/13 15:20, Mark Brown wrote: > On Tue, Jul 23, 2013 at 02:59:06PM +0200, Sebastian Hesselbarth wrote: >> On 07/23/13 14:34, Mark Brown wrote: > >>> As others have pointed out if you need to change the clock get code >>> there's something wrong here, DT should be handled transparently by the >>> clock API. > >> IMHO the reason why of_clk_get() was/is mis-used in that way is mostly >> compatibility with legacy platform_data based setup. > > I'm sorry, but this doesn't make a great deal of sense to me. Can you > be more specific? > >> As Sascha Hauer pointed out, clocks should be distinguished by names >> (clock-names property) instead of position and then use >> devm_clk_get(&pdev->dev, "internal") and >> devm_clk_get(&pdev->dev, "external") respectively. > >> This will possibly also require to update platform_data and legacy >> users of kirkwood-i2s or have different setup functions for non-DT >> and DT. > > Why would this be required? The driver is already asking for multiple > clocks...
The driver is asking for multiple *DT based* clocks. Legacy platform_data has never been updated to reflect that. Mainly because multiple clocks are only supported on Dove, which has no active non-DT board in mainline.
>> Also, while ASoC API separates the audio-controller into cpu-side >> and codec-side parts, the DT should not. IIRC and as Russell repeated > > You mean DAI and DMA here? I already commented on that in my review of > the DMA binding.
Yes.
>> again, we mentioned to merge kirkwood-i2s.c and kirkwood-dma.c into >> a single file, didn't we? > > That's been discussed several times but nobody's actually done it.
Correct, that is why I repeated that request to Jean-Francois.
Sebastian
| |