lkml.org 
[lkml]   [2013]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Staging: bcm: Qos: Fix some coding style issues
    From
    Date
    Hi Dan,

    I have already accepted my fate when I submitted the patch. Though it's
    really great that I receive a response so fast :)

    Regarding the braces, I thought it would be more readable that way
    because of the long code wrapping inside the "if" parameter. I'll fix it
    and send the patches again in pieces. Should I send a new mail or reply
    to this thread?

    Lilis

    On Tue, 2013-07-23 at 12:54 +0300, Dan Carpenter wrote:
    > Hi hi,
    >
    > Welcome first time submitter newbie. :) The tradition is to reject
    > first time code submissions in the meanest and grumpiest way
    > possible.
    >
    > On Tue, Jul 23, 2013 at 05:20:29PM +0800, Lilis Iskandar wrote:
    > > >From a2f8b299baee0e075d548d2bbf77619373035446 Mon Sep 17 00:00:00 2001
    > > From: Lilis Iskandar <veeableful@gmail.com>
    > > Date: Tue, 23 Jul 2013 17:08:37 +0800
    > > Subject: [PATCH] Staging: bcm: Qos: Fix some coding style issues
    >
    > This header stuff is not needed. See if you can figure out how to
    > get rid of it.
    >
    > You are fixing too many kinds of problems at once so the patch is
    > impossible to review. Please break it up into one kind of issue
    > per patch.
    >
    > > - if(FALSE == (bClassificationSucceed =
    > > + if (FALSE == (bClassificationSucceed =
    > > MatchSrcPort(pstClassifierRule,
    > > - ntohs((iphd->protocol == UDP)?
    > > - xprt_hdr->uhdr.source:xprt_hdr->thdr.source))))
    > > + ntohs((iphd->protocol == UDP)?
    > > + xprt_hdr->uhdr.source : xprt_hdr->thdr.source))))
    > > + {
    > > break;
    > > + }
    >
    > I don't know why you are adding curly braces here but they don't
    > belong. Braces are explained in CodingStyle.
    >
    > regards,
    > dan carpenter
    >




    \
     
     \ /
      Last update: 2013-07-23 12:41    [W:3.237 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site