lkml.org 
[lkml]   [2013]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH 1/7] tracing: Introduce trace_create_cpu_file() and tracing_get_cpu()
From
Date
On Mon, 2013-07-22 at 19:15 +0200, Oleg Nesterov wrote:

> > Otherwise, you might want to fix them if you need
> > to send a follow up patch set.
>
> Yes, will do.
>

After applying your patches, my tests crashed the kernel. It's fixed
with the following update. I guess you should merge this into your next
version.

-- Steve

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 5e5ff44..db561b5 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2984,7 +2984,7 @@ static int tracing_release(struct inode *inode, struct file *file)
{
struct trace_array *tr = inode->i_private;
struct seq_file *m = file->private_data;
- struct trace_iterator *iter = m->private;
+ struct trace_iterator *iter;
int cpu;

if (!(file->f_mode & FMODE_READ)) {
@@ -2992,6 +2992,9 @@ static int tracing_release(struct inode *inode, struct file *file)
return 0;
}

+ /* Writes do not use seq_file */
+ iter = m->private;
+
mutex_lock(&trace_types_lock);

for_each_tracing_cpu(cpu) {



\
 
 \ /
  Last update: 2013-07-23 03:21    [W:0.139 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site