lkml.org 
[lkml]   [2013]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/7] tracing: Kill the buggy trace_cpu
From
Date
On Mon, 2013-07-22 at 15:43 +0200, Oleg Nesterov wrote:
> Hello.
>
> Only slightly tested so far. I'll try to test more and report
> the results.
>
> Meanwhile it would be nice if you can take a look and review.
>
>
> This series kills tracing_open_generic_tc/trace_cpu/etc.
>
> trace_array_get(inode->i_private) is mostly fine, we do not
> dereference this pointer untill trace_array_get() succeeds.
> But trace_array_get(tc->tr) is wrong by the same reason why
> tracing_open_generic_file/etc are wrong, see 1/7.
>
> And not only trace_cpu is buggy, we can simplify the code if
> we kill this member.
>

Oleg,

So far I like the patch set. I just want to get Al's OK before we do a
hack with an inode structure item.

Thanks!

-- Steve




\
 
 \ /
  Last update: 2013-07-22 17:41    [W:0.100 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site