lkml.org 
[lkml]   [2013]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] kprobes/x86: Remove an incorrect comment about int3 in NMI/MCE
    Commit-ID:  c7e85c42be68fca743df58a306edd29aa295e155
    Gitweb: http://git.kernel.org/tip/c7e85c42be68fca743df58a306edd29aa295e155
    Author: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    AuthorDate: Thu, 18 Jul 2013 20:47:47 +0900
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitDate: Fri, 19 Jul 2013 09:57:03 +0200

    kprobes/x86: Remove an incorrect comment about int3 in NMI/MCE

    Remove a comment about an int3 issue in NMI/MCE, since
    commit:

    3f3c8b8c4b2a ("x86: Add workaround to NMI iret woes")

    already fixed that. Keeping this incorrect comment can mislead developers.

    Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    Reviewed-by: Jiri Kosina <jkosina@suse.cz>
    Cc: H. Peter Anvin <hpa@linux.intel.com>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Jason Baron <jbaron@akamai.com>
    Cc: yrl.pp-manager.tt@hitachi.com
    Cc: Borislav Petkov <bpetkov@suse.de>
    Link: http://lkml.kernel.org/r/20130718114747.26675.84110.stgit@mhiramat-M0-7522
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    arch/x86/kernel/kprobes/opt.c | 10 ----------
    1 file changed, 10 deletions(-)

    diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c
    index 76dc6f0..d7d8a8c 100644
    --- a/arch/x86/kernel/kprobes/opt.c
    +++ b/arch/x86/kernel/kprobes/opt.c
    @@ -415,11 +415,6 @@ void __kprobes arch_optimize_kprobes(struct list_head *oplist)
    break;
    }

    - /*
    - * text_poke_smp doesn't support NMI/MCE code modifying.
    - * However, since kprobes itself also doesn't support NMI/MCE
    - * code probing, it's not a problem.
    - */
    text_poke_smp_batch(jump_poke_params, c);
    }

    @@ -455,11 +450,6 @@ extern void arch_unoptimize_kprobes(struct list_head *oplist,
    break;
    }

    - /*
    - * text_poke_smp doesn't support NMI/MCE code modifying.
    - * However, since kprobes itself also doesn't support NMI/MCE
    - * code probing, it's not a problem.
    - */
    text_poke_smp_batch(jump_poke_params, c);
    }


    \
     
     \ /
      Last update: 2013-07-21 16:21    [W:4.398 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site