Messages in this thread | | | Subject | Re: [PATCH v3 02/12] tracing: fix irqs-off tag display in syscall tracing | From | Steven Rostedt <> | Date | Tue, 02 Jul 2013 19:25:24 -0400 |
| |
On Wed, 2013-04-10 at 11:26 +0800, zhangwei(Jovi) wrote: > From: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com> > > Now all syscall tracing irqs-off tag is wrong, > syscall enter entry doesn't disable irq. > > [root@jovi tracing]#echo "syscalls:sys_enter_open" > set_event > [root@jovi tracing]# cat trace > # tracer: nop > # > # entries-in-buffer/entries-written: 13/13 #P:2 > # > # _-----=> irqs-off > # / _----=> need-resched > # | / _---=> hardirq/softirq > # || / _--=> preempt-depth > # ||| / delay > # TASK-PID CPU# |||| TIMESTAMP FUNCTION > # | | | |||| | | > irqbalance-513 [000] d... 56115.496766: sys_open(filename: 804e1a6, flags: 0, mode: 1b6) > irqbalance-513 [000] d... 56115.497008: sys_open(filename: 804e1bb, flags: 0, mode: 1b6) > sendmail-771 [000] d... 56115.827982: sys_open(filename: b770e6d1, flags: 0, mode: 1b6) > > The reason is syscall tracing doesn't record irq_flags into buffer. > Fix this after this patch: > > [root@jovi tracing]#echo "syscalls:sys_enter_open" > set_event > [root@jovi tracing]# cat trace > # tracer: nop > # > # entries-in-buffer/entries-written: 14/14 #P:2 > # > # _-----=> irqs-off > # / _----=> need-resched > # | / _---=> hardirq/softirq > # || / _--=> preempt-depth > # ||| / delay > # TASK-PID CPU# |||| TIMESTAMP FUNCTION > # | | | |||| | | > irqbalance-514 [001] .... 46.213921: sys_open(filename: 804e1a6, flags: 0, mode: 1b6) > irqbalance-514 [001] .... 46.214160: sys_open(filename: 804e1bb, flags: 0, mode: 1b6) > <...>-920 [001] .... 47.307260: sys_open(filename: 4e82a0c5, flags: 80000, mode: 0) > > Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com> > ---
I'll pull this one in for 3.11 and mark for stable.
Thanks,
-- Steve
| |