Messages in this thread | | | Date | Tue, 02 Jul 2013 17:25:46 +0200 | From | Lars-Peter Clausen <> | Subject | Re: [alsa-devel] [PATCH 1/2] ASoC: atmel_ssc_dai: move set dma data to startup callback |
| |
On 07/02/2013 11:04 AM, Bo Shen wrote: [...] > + dma_params->substream = substream;
Unrelated to this patch, but having a substream field in the dma_params seems to be redundant, since you need to know the substream to get the dma_params in the first place. Looking at the code it also seems to be unused other than this assignment. Maybe you can send a follow up patch to remove it.
[...]
| |