lkml.org 
[lkml]   [2013]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 63/72] ARM: 7778/1: smp_twd: twd_update_frequency need be run on all online CPUs
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jason Liu <r64343@freescale.com>

    commit cbbe6f82b489e7ceba4ad7c833bd3a76cd0084cb upstream.

    When the local timer freq changed, the twd_update_frequency function
    should be run all the CPUs include itself, otherwise, the twd freq will
    not get updated and the local timer will not run correcttly.

    smp_call_function will run functions on all other CPUs, but not include
    himself, this is not correct,use on_each_cpu instead to fix this issue.

    Acked-by: Linus Walleij <linus.walleij@linaro.org>
    Cc: Linus Walleij <linus.walleij@linaro.org>
    Cc: Rob Herring <rob.herring@calxeda.com>
    Cc: Shawn Guo <shawn.guo@linaro.org>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Acked-by: Shawn Guo <shawn.guo@linaro.org>
    Signed-off-by: Jason Liu <r64343@freescale.com>
    Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/arm/kernel/smp_twd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/arm/kernel/smp_twd.c
    +++ b/arch/arm/kernel/smp_twd.c
    @@ -120,7 +120,7 @@ static int twd_rate_change(struct notifi
    * changing cpu.
    */
    if (flags == POST_RATE_CHANGE)
    - smp_call_function(twd_update_frequency,
    + on_each_cpu(twd_update_frequency,
    (void *)&cnd->new_rate, 1);

    return NOTIFY_OK;



    \
     
     \ /
      Last update: 2013-07-19 08:21    [W:4.937 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site