Messages in this thread | | | Date | Fri, 19 Jul 2013 12:07:31 +0100 | From | Srinivas KANDAGATLA <> | Subject | Re: [PATCH v1 1/2] media: rc: Add user count to rc dev. |
| |
On 19/07/13 12:01, Sean Young wrote:
>> + int rval = 0; >> >> - return rdev->open(rdev); >> + if (!rdev->users++) >> + rval = rdev->open(rdev); >> + >> + if (rval) >> + rdev->users--; >> + >> + return rval; > > This looks racey. Some locking is needed, I think rc_dev->lock should work > fine for this. Here and in the lirc code path too. thanks Sean, It makes sense, will fix this in v2.
Srini
> > Sean > >> } >
| |