lkml.org 
[lkml]   [2013]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 07/15] iio: ti_am335x_adc: Handle set to clear IRQSTATUS
Date
From: Russ Dill <Russ.Dill@ti.com>

The driver is currently mishandling the IRQSTATUS register by peforming
a read/update/write cycle. The actual functionality of the register is as follows:

Write 0 = No action.
Read 0 = No (enabled) event pending.
Read 1 = Event pending.
Write 1 = Clear (raw) event.

By reading the status and writing it back, the driver is clearing
all pending events, not just the one indicated in the bitmask.

Signed-off-by: Russ Dill <Russ.Dill@ti.com>
Signed-off-by: Zubair Lutfullah <zubair.lutfullah@gmail.com>
---
drivers/iio/adc/ti_am335x_adc.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
index b566e6a..1c47818 100644
--- a/drivers/iio/adc/ti_am335x_adc.c
+++ b/drivers/iio/adc/ti_am335x_adc.c
@@ -178,7 +178,7 @@ static irqreturn_t tiadc_irq(int irq, void *private)
wake_up_interruptible(&adc_dev->wq_data_avail);
}
tiadc_writel(adc_dev, REG_IRQSTATUS,
- (status | IRQENB_FIFO1THRES));
+ IRQENB_FIFO1THRES);
return IRQ_HANDLED;
} else if ((status & IRQENB_FIFO1OVRRUN) ||
(status & IRQENB_FIFO1UNDRFLW)) {
@@ -186,12 +186,9 @@ static irqreturn_t tiadc_irq(int irq, void *private)
config &= ~(CNTRLREG_TSCSSENB);
tiadc_writel(adc_dev, REG_CTRL, config);

- if (status & IRQENB_FIFO1UNDRFLW)
- tiadc_writel(adc_dev, REG_IRQSTATUS,
- (status | IRQENB_FIFO1UNDRFLW));
- else
- tiadc_writel(adc_dev, REG_IRQSTATUS,
- (status | IRQENB_FIFO1OVRRUN));
+ tiadc_writel(adc_dev, REG_IRQSTATUS,
+ IRQENB_FIFO1OVRRUN |
+ IRQENB_FIFO1UNDRFLW);

tiadc_writel(adc_dev, REG_CTRL,
(config | CNTRLREG_TSCSSENB));
--
1.7.9.5


\
 
 \ /
  Last update: 2013-07-19 03:42    [W:0.596 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site