Messages in this thread | | | Date | Thu, 18 Jul 2013 15:01:02 -0700 | Subject | Re: [PATCH v2] kconfig: switch to "long long" for sanity | From | Kees Cook <> |
| |
On Thu, Jul 18, 2013 at 1:47 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Kees, Geert, All, > > On 2013-07-18 22:00 +0200, Geert Uytterhoeven spake thusly: >> On Thu, Jul 18, 2013 at 8:32 PM, Kees Cook <keescook@chromium.org> wrote: >> > Instead of using "long" for kconfig "hex" and "range" values, which may >> > change in size depending on the host architecture, use "long long". This >> > will allow values greater than INT_MAX on 32-bit hosts when cross >> > compiling. >> > >> > Signed-off-by: Kees Cook <keescook@chromium.org> >> >> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Ok, thanks, I'll take in my tree. > > Is it material for -rc-fixes, or can it wait in -for-next? > > My gut feelings is that it does not fix an existing breakage, but only a > potential problem in the future, so it would be a candidate for > -for-next. Agreed?
Correct. I'm not aware of anything in the tree that currently uses >INT_MAX values in kconfig.
-Kees
-- Kees Cook Chrome OS Security
| |