Messages in this thread | | | Date | Thu, 18 Jul 2013 20:01:43 +0200 | Subject | Re: [PATCH] kconfig: switch to "long long" for sanity | From | Geert Uytterhoeven <> |
| |
On Thu, Jul 18, 2013 at 6:06 PM, Kees Cook <keescook@chromium.org> wrote: > Instead of using "long" for kconfig "hex" and "range" values, which may > change in size depending on the host architecture, use "long long". This > will allow values greater than INT_MAX on 32-bit hosts when cross > compiling. > > Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> with one minor nit...
> static void sym_validate_range(struct symbol *sym) > { > struct property *prop; > - long base, val, val2; > + long long base, val, val2;
strtoll() expects an "int" type for "base". This was changed to "long" in your previous patch.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |