lkml.org 
[lkml]   [2013]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH V2] tracing/kprobe: Wait for disabling all running kprobe handlers
    From
    Date
    On Thu, 2013-07-18 at 21:07 +0900, Masami Hiramatsu wrote:
    > (2013/07/16 3:20), Oleg Nesterov wrote:
    > > On 07/09, Masami Hiramatsu wrote:
    > >>
    > >> Wait for disabling all running kprobe handlers when a kprobe
    > >> event is disabled, since the caller, trace_remove_event_call()
    > >> supposes that a removing event is disabled completely by
    > >> disabling the event.
    > >> With this change, ftrace can ensure that there is no running
    > >> event handlers after disabling it.
    > >>
    > >> Changes in V2:
    > >> - Comment (in code) for clarify why we need to wait there.
    > >>
    > >> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    > >
    > > Agreed.
    > >
    > > We need this change in any case, whatever we do in trace/trace_events.c
    > > and in unregister_trace_probe().
    >
    > Steven, I think this patch is still needed anyway even if we are
    > discussing file handling bugs, because this fixes another timing bug.

    Sure, I'll pull that into my queue now.

    -- Steve




    \
     
     \ /
      Last update: 2013-07-18 17:01    [W:2.889 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site