Messages in this thread | | | Subject | Re: [PATCH] ioatdma: silence GCC warnings | From | Paul Bolle <> | Date | Thu, 18 Jul 2013 13:42:37 +0200 |
| |
On Wed, 2013-07-17 at 15:39 -0700, Dan Williams wrote: > On Mon, Jun 17, 2013 at 3:35 AM, Paul Bolle <pebolle@tiscali.nl> wrote: > Seems this is fixed in gcc as of 4.7.2, but we can make things quieter > for build testers on older compilers.
Well, I'm currently using gcc (GCC) 4.7.2 20121109 (Red Hat 4.7.2-8)
as shipped for Fedora 18.
> > diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c > > index ca6ea9b..b5102da 100644 > > --- a/drivers/dma/ioat/dma_v3.c > > +++ b/drivers/dma/ioat/dma_v3.c > > @@ -251,7 +251,7 @@ static bool is_bwd_noraid(struct pci_dev *pdev) > > } > > > > static void pq16_set_src(struct ioat_raw_descriptor *desc[3], > > - dma_addr_t addr, u32 offset, u8 coef, int idx) > > + dma_addr_t addr, u32 offset, u8 coef, unsigned int idx) > > "unsigned int" --> "unsigned"
Fine with me, but it does introduce a second form in this file (it already uses "unsigned int" a few times).
> > { > > struct ioat_pq_descriptor *pq = (struct ioat_pq_descriptor *)desc[0]; > > struct ioat_pq16a_descriptor *pq16 = > > Just do this hunk as the minimal one line change.
You're right. Just this hunk is enough. I'll try to send a v2 shortly.
Paul Bolle
| |