lkml.org 
[lkml]   [2013]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 008/145] clocksource: dw_apb: Fix error check
    Date
    3.8.13.5 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Baruch Siach <baruch@tkos.co.il>

    commit 1a33bd2be705cbb3f57d7223b60baea441039307 upstream.

    irq_of_parse_and_map() returns 0 on error, while the code checks for NO_IRQ.
    This breaks on platforms that have NO_IRQ != 0.

    Signed-off-by: Baruch Siach <baruch@tkos.co.il>
    Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/clocksource/dw_apb_timer_of.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/clocksource/dw_apb_timer_of.c b/drivers/clocksource/dw_apb_timer_of.c
    index f7dba5b..929e7ce 100644
    --- a/drivers/clocksource/dw_apb_timer_of.c
    +++ b/drivers/clocksource/dw_apb_timer_of.c
    @@ -44,7 +44,7 @@ static void add_clockevent(struct device_node *event_timer)
    u32 irq, rate;

    irq = irq_of_parse_and_map(event_timer, 0);
    - if (irq == NO_IRQ)
    + if (irq == 0)
    panic("No IRQ for clock event timer");

    timer_get_base_and_rate(event_timer, &iobase, &rate);
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-07-18 16:43    [W:4.182 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site