lkml.org 
[lkml]   [2013]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 111/145] svcrpc: don't error out on small tcp fragment
    Date
    3.8.13.5 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "J. Bruce Fields" <bfields@redhat.com>

    commit 1f691b07c5dc51b2055834f58c0f351defd97f27 upstream.

    Though clients we care about mostly don't do this, it is possible for
    rpc requests to be sent in multiple fragments. Here we have a sanity
    check to ensure that the final received rpc isn't too small--except that
    the number we're actually checking is the length of just the final
    fragment, not of the whole rpc. So a perfectly legal rpc that's
    unluckily fragmented could cause the server to close the connection
    here.

    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    net/sunrpc/svcsock.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
    index df74919..305374d 100644
    --- a/net/sunrpc/svcsock.c
    +++ b/net/sunrpc/svcsock.c
    @@ -1095,7 +1095,7 @@ static int svc_tcp_recvfrom(struct svc_rqst *rqstp)
    goto err_noclose;
    }

    - if (svc_sock_reclen(svsk) < 8) {
    + if (svsk->sk_datalen < 8) {
    svsk->sk_datalen = 0;
    goto err_delete; /* client is nuts. */
    }
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-07-18 10:21    [W:2.287 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site