Messages in this thread | | | Date | Wed, 17 Jul 2013 09:36:57 -0700 | Subject | Re: [PATCH] arm, kbuild: make "make install" not depend on vmlinux | From | Linus Torvalds <> |
| |
On Wed, Jul 17, 2013 at 9:05 AM, Robert Richter <rric@kernel.org> wrote: > > I narrowed this down. The problem is that zinstall on ARCH=arm has a > dependency to vmlinux which does a prepare/prepare3 and finally does a > forced rebuild of kernel.release even if it exists already. > > Rebuilding it removes kernel.release first and then recreates it. This > might race with another parallel make job running depmod. > > So on arm and maybe other archs we need the same as for x86: > > 1648e4f8 x86, kbuild: make "make install" not depend on vmlinux > > The patch below fixes this for arm. It is build-tested in my > environment, but please test it in others too if possible.
Ack. This looks like the right thing to do.
That said, I think for clarity you might perhaps want to make the unrelated change of adding double quotes around $(KERNELRELEASE) a separate patch. Not a big deal, but it took me a moment to say "why did he do that" (in fact, I'm not sure KERNEL_RELEASE can actually validly have spaces in it, but quoting it is certainly not wrong either - but it might be unnecessary.
Linus
| |