Messages in this thread | | | Subject | Re: [PATCH 0/3] tracing/perf: perf_trace_buf/perf_xxx hacks. | From | Steven Rostedt <> | Date | Wed, 17 Jul 2013 23:06:42 -0400 |
| |
On Tue, 2013-06-18 at 21:21 +0200, Oleg Nesterov wrote: > Hello. > > On top of "PATCH 0/3] tracing: more list_empty(perf_events) checks" > series I sent yesterday. > > Compile tested only, not for inclusion yet.
Oleg, I know you sent me a mbox with these patches, but I rather pull the real email. But this is the only one I have. With a comment like that, I wouldn't pull it in.
But as you sent me them to include them, I take it, this is ready.
Peter, Frederic, can you review these patches and ack or nack them?
Thanks,
-- Steve
> > But I'll appreciate if you can take a look. I'll try to test this > tomorrow somehow and let you know. Right now I am looking at asm code, > looks correct... > > I also compiled the kernel with the additional patch below, everything > compiles except sched/core.o as expected. > > Oleg. > > --- a/include/trace/ftrace.h > +++ b/include/trace/ftrace.h > @@ -664,6 +664,8 @@ perf_trace_##call(void *__data, proto) \ > \ > __data_size = ftrace_get_offsets_##call(&__data_offsets, args); \ > \ > + BUILD_BUG_ON(!(__builtin_constant_p(!__task) && !__task)); \ > + \ > head = this_cpu_ptr(event_call->perf_events); \ > if (__builtin_constant_p(!__task) && !__task && \ > hlist_empty(head)) \
| |