lkml.org 
[lkml]   [2013]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 076/145] ipvs: info leak in __ip_vs_get_dest_entries()
    Date
    3.8.13.5 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit a8241c63517ec0b900695daa9003cddc41c536a1 upstream.

    The entry struct has a 2 byte hole after ->port and another 4 byte
    hole after ->stats.outpkts. You must have CAP_NET_ADMIN in your
    namespace to hit this information leak.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Julian Anastasov <ja@ssi.bg>
    Signed-off-by: Simon Horman <horms@verge.net.au>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    net/netfilter/ipvs/ip_vs_ctl.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
    index ec664cb..5f929a7 100644
    --- a/net/netfilter/ipvs/ip_vs_ctl.c
    +++ b/net/netfilter/ipvs/ip_vs_ctl.c
    @@ -2556,6 +2556,7 @@ __ip_vs_get_dest_entries(struct net *net, const struct ip_vs_get_dests *get,
    struct ip_vs_dest *dest;
    struct ip_vs_dest_entry entry;

    + memset(&entry, 0, sizeof(entry));
    list_for_each_entry(dest, &svc->destinations, n_list) {
    if (count >= get->num_dests)
    break;
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-07-18 02:01    [W:4.137 / U:0.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site