Messages in this thread | | | Subject | Re: [RFC PATCH 3/4] tracing: Kill tracing_open/release_generic_file | From | Steven Rostedt <> | Date | Tue, 16 Jul 2013 15:51:35 -0400 |
| |
On Tue, 2013-07-16 at 20:57 +0200, Oleg Nesterov wrote: > Kill tracing_open_generic_file() and tracing_release_generic_file(), > they are racy anyway. > > Instead, change event_enable_read() and event_enable_write() to rely > on event_mutex and file_inode(filp)->i_private != NULL check. > > trace_array_get() goes away. NOTE! this is actually wrong until we > change instance_delete() path to nullify ->i_private.
I think this needs to be done first. Want me to take a crack at it, and we can interleave our patches if needed.
-- Steve
| |