Messages in this thread | | | Date | Tue, 16 Jul 2013 09:38:39 -0300 | Subject | Re: [PATCH 2/5] ARM: mxs-lradc: Simplify mxs_lradc_trigger_init error handle | From | Otavio Salvador <> |
| |
On Mon, Jul 15, 2013 at 8:00 PM, Marek Vasut <marex@denx.de> wrote: > Dear Otavio Salvador, > >> On Mon, Jul 15, 2013 at 11:24 AM, Marek Vasut <marek.vasut@gmail.com> wrote: >> > Dear Otavio Salvador, >> > >> >> As we have a 'ret' variable with the iio_trigger_register return, this >> >> can be used as result. >> >> >> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> >> >> --- >> >> >> >> drivers/staging/iio/adc/mxs-lradc.c | 6 ++---- >> >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> >> >> diff --git a/drivers/staging/iio/adc/mxs-lradc.c >> >> b/drivers/staging/iio/adc/mxs-lradc.c index d92c97a..6d41846 100644 >> >> --- a/drivers/staging/iio/adc/mxs-lradc.c >> >> +++ b/drivers/staging/iio/adc/mxs-lradc.c >> >> @@ -671,14 +671,12 @@ static int mxs_lradc_trigger_init(struct iio_dev >> >> *iio) trig->ops = &mxs_lradc_trigger_ops; >> >> >> >> ret = iio_trigger_register(trig); >> >> >> >> - if (ret) { >> >> + if (ret) >> >> >> >> iio_trigger_free(trig); >> >> >> >> - return ret; >> >> - } >> >> >> >> iio->trig = trig; >> > >> > You are still setting iio->trig , you dont want to do that in case of >> > failure >> >> In this case it'd end being NULL I think, wouldn't it? > > It won't, see the implementation in: > > drivers/iio/industrialio-trigger.c
Agreed; will drop this from v2.
-- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
| |