lkml.org 
[lkml]   [2013]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] regulator: pfuze100: add pfuze100 regulator driver
On Mon, Jul 15, 2013 at 02:40:39PM +0800, Robin Gong wrote:
> > > +static const struct of_device_id pfuze_dt_ids[] = {
> > > + { .compatible = "fsl,pfuze100", .data = (void *)PFUZE_ID_PFUZE100},
> >
> > You do not use .data in the driver at all, and can just drop it.
> >
> good catch. .driver_data of i2c_device_id and .data of of_device_id are two different ways to let driver know which chip used now by DTS or not. I should use them to know which chip used now ,although I can know by reading chipid register.
>

If you can figure out the chip ID from hardware, it should be used as
the preference over compatible and .driver_data.

Shawn



\
 
 \ /
  Last update: 2013-07-15 09:21    [W:0.037 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site