Messages in this thread | | | From | Prabhakar Lad <> | Date | Mon, 15 Jul 2013 22:39:06 +0530 | Subject | Re: [PATCH v2 2/2] media: i2c: tvp7002: add OF support |
| |
Hi Sylwester,
On Mon, Jul 15, 2013 at 1:12 AM, Sylwester Nawrocki <sylvester.nawrocki@gmail.com> wrote: > Hi Prabhakar, > [Snip] >> Something similar to fid_polarity. > > > Then as I suggested earlier, let's just add 'sync-on-green-active' DT > property for that. I wouldn't expect the DT properties to be directly > replacing your driver platform_data members. Saying in the binding that > this is a normal operation and that is an inverted one is not very useful > in general, as you would need to dig in the binding's description what > "normal" exactly means. sync-on-green-active = <1>; seems much more > explicit than, e.g. sync-on-green-inverted. By looking at the > sync-on-green-active property each device driver would determine whether > it means normal or inverted operation for its device. > Ok so I'll add 'sync-on-green-active' property and parse it in v4l2_of_parse_parallel_bus() and add it as part of flags. and define the following flags in mediabus.h
V4L2_MBUS_VIDEO_SOG_ACTIVE_{HIGH,LOW}.
Hope you are OK with it.
-- Regards, Prabhakar Lad
| |