lkml.org 
[lkml]   [2013]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/9] mm, hugetlb: remove redundant list_empty check in gather_surplus_pages()
    Date
    If list is empty, list_for_each_entry_safe() doesn't do anything.
    So, this check is redundant. Remove it.

    Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

    diff --git a/mm/hugetlb.c b/mm/hugetlb.c
    index a838e6b..d4a1695 100644
    --- a/mm/hugetlb.c
    +++ b/mm/hugetlb.c
    @@ -1019,10 +1019,8 @@ free:
    spin_unlock(&hugetlb_lock);

    /* Free unnecessary surplus pages to the buddy allocator */
    - if (!list_empty(&surplus_list)) {
    - list_for_each_entry_safe(page, tmp, &surplus_list, lru) {
    - put_page(page);
    - }
    + list_for_each_entry_safe(page, tmp, &surplus_list, lru) {
    + put_page(page);
    }
    spin_lock(&hugetlb_lock);

    --
    1.7.9.5


    \
     
     \ /
      Last update: 2013-07-15 13:42    [W:7.666 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site