Messages in this thread | | | Date | Sat, 13 Jul 2013 09:07:16 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging/lustre/libcfs: fix typo "default false" |
| |
On Sat, Jul 13, 2013 at 04:40:46PM +0200, Paul Bolle wrote: > Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added > "default false" to this Kconfig file. It was obviously meant to use > "default n" here. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > 0) Tested lightly, with "make menuconfig" only. > > 1) No-one noticed because "default <invalid Kconfig symbol>" and > "default n" behave the same. Actually, it seems "default n" isn't needed > at all. But there are hundreds of Kconfig symbols that use "default n", > so I suppose it serves some purpose. > > drivers/staging/lustre/lustre/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig > index e0eb830..002dd2e 100644 > --- a/drivers/staging/lustre/lustre/Kconfig > +++ b/drivers/staging/lustre/lustre/Kconfig > @@ -43,7 +43,7 @@ config LUSTRE_OBD_MAX_IOCTL_BUFFER > config LUSTRE_DEBUG_EXPENSIVE_CHECK > bool "Enable Lustre DEBUG checks" > depends on LUSTRE_FS > - default false > + default n
Just remove it entirely, as you say, the default is 'n', so let's just stick with that.
Care to redo this?
thanks,
greg k-h
| |