Messages in this thread | | | Subject | Re: [PATCH 5/5] media: davinci: vpbe: Replace printk with dev_* | From | Joe Perches <> | Date | Sat, 13 Jul 2013 06:07:23 -0700 |
| |
On Sat, 2013-07-13 at 14:20 +0530, Prabhakar Lad wrote: > Use the dev_* message logging API instead of raw printk. [] > diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c [] > @@ -735,7 +735,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev) > > mutex_unlock(&vpbe_dev->lock); > > - printk(KERN_NOTICE "Setting default output to %s\n", def_output); > + dev_info(dev, "Setting default output to %s\n", def_output);
You are changing logging levels too. You should mention that in the changelog.
> @@ -743,7 +743,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev) > return ret; > } > > - printk(KERN_NOTICE "Setting default mode to %s\n", def_mode); > + dev_info(dev, "Setting default mode to %s\n", def_mode); > ret = vpbe_set_default_mode(vpbe_dev); > if (ret) { > v4l2_err(&vpbe_dev->v4l2_dev, "Failed to set default mode %s",
Maybe these should be v4l2_notice() which could be added to include/media/v4l2-common.h
| |