Messages in this thread | | | Date | Fri, 12 Jul 2013 18:30:00 -0700 | From | Greg KH <> | Subject | Re: [PATCH] misc: add driver for Renesas R-Car Gyro-ADC/speed-pulse interfaces |
| |
On Sat, Jul 13, 2013 at 05:15:16AM +0400, Sergei Shtylyov wrote: > Hello. > > Can't get to sleep, sigh... > > On 07/13/2013 04:57 AM, Greg KH wrote: > > >>Add the driver for Gyro-ADC/speed-pulse interfaces found in Renesas R-Car SoCs. > >>Though being two separate devices, they have to be driven together because of > >>the shared start/stop register (located in Gyro-ADC still). At this time, only > >>speed-pulse interface is fully supported, the Gyro-ADC is just initialized and > >>started/stopped synchronously with the speed-pulse interface. A user interface > >>is implemented via several sysfs files which allow to read and reset the speed- > >>pulse interface's registers. > > >If you modify/create/remove sysfs files, you also have to document them > >in Documentation/ABI/ which is missing from this patch. > > I've looked there and didn't find the documentation for my closest > model driver, drivers/misc/ti_dac7512.c (or for many other drivers), > so I thought I too can do without it.
Nope, that driver should be fixed as well, care to do so?
> >Your sysfs files are also being created in a "racy" way, i.e. after > >userspace is told about the device, please fix that as well. > > Not sure I understand you. Could you elaborate?
Please read the driver model documentation, it goes into the details of how to do this properly. As does this post from me a week or so ago: http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/
greg k-h
| |