lkml.org 
[lkml]   [2013]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()
On 07/12/2013 12:47 AM, Steven Rostedt wrote:
> On Thu, 2013-07-11 at 08:31 +0800, Chen Gang wrote:
>> Like other trace_selftest_startup_*, trace_selftest_startup_function()
>> and trace_selftest_startup_function_graph() need in normal section, or
>> may cause section mismatch.
>>
>> The related warnings:
>>
>> LD kernel/trace/built-in.o
>> WARNING: kernel/trace/built-in.o(.data+0x154c): Section mismatch in reference from the variable function_trace to the function .init.text:trace_selftest_startup_function()
>> The variable function_trace references
>> the function __init trace_selftest_startup_function()
>> If the reference is valid then annotate the
>> variable with __init* or __refdata (see linux/init.h) or name the variable:
>> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
>>
>
> No the fix is to add ref_data to the user. The selftest are only called
> at boot up. No need to waste memory keeping them around.
>

Ok, thanks.

Hmm, can all trace_selftest_startup_* (*selftest* in trace_selftest.c)
use '__init', so not waste memory keeping them around ?


Thanks.
--
Chen Gang


\
 
 \ /
  Last update: 2013-07-12 02:21    [W:0.068 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site