lkml.org 
[lkml]   [2013]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: mempolicy: turn vma_set_policy() into vma_dup_policy()
On Thu, 11 Jul 2013 15:13:03 -0700 (PDT) David Rientjes <rientjes@google.com> wrote:

> > +int vma_dup_policy(struct vm_area_struct *src, struct vm_area_struct *dst)
> > +{
> > + struct mempolicy *pol = mpol_dup(vma_policy(src));
> > +
> > + if (IS_ERR(pol))
> > + return PTR_ERR(pol);
>
> PTR_ERR() returns long, so vma_dup_policy() needs to return long.

hm, really? vma_dup_policy() returns an errno and errnos have type "int".

Arguably it is PTR_ERR() which returns the wrong type...


\
 
 \ /
  Last update: 2013-07-12 01:01    [W:0.059 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site