Messages in this thread | | | Date | Thu, 11 Jul 2013 15:20:06 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] mm: mempolicy: turn vma_set_policy() into vma_dup_policy() |
| |
On Thu, 11 Jul 2013 15:13:03 -0700 (PDT) David Rientjes <rientjes@google.com> wrote:
> > +int vma_dup_policy(struct vm_area_struct *src, struct vm_area_struct *dst) > > +{ > > + struct mempolicy *pol = mpol_dup(vma_policy(src)); > > + > > + if (IS_ERR(pol)) > > + return PTR_ERR(pol); > > PTR_ERR() returns long, so vma_dup_policy() needs to return long.
hm, really? vma_dup_policy() returns an errno and errnos have type "int".
Arguably it is PTR_ERR() which returns the wrong type...
| |