lkml.org 
[lkml]   [2013]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] [PATCH 1/2 v2] x86: introduce int3-based instruction patching
    On Thu, 11 Jul 2013, H. Peter Anvin wrote:

    > >> + * The way it is done:
    > >> + * - add a int3 trap to the address that will be patched
    > >> + * - sync cores
    > >
    > > You don't need this "sync cores". (and your code didn't) :)
    >
    > I believe you do, lest you get "Frankenstructions". I believe you don't
    > need the second one, however. I should dig up my notes on this.

    I found this post from 2010 from you:

    http://lkml.indiana.edu/hypermail/linux/kernel/1001.1/01530.html

    If it's still valid and you guys at Intel haven't discovered any reason
    why that procedure would be invalid, I'll send out v3 with that'd be using
    exactly this ordering of syncing of the cores.

    Thanks,

    --
    Jiri Kosina
    SUSE Labs


    \
     
     \ /
      Last update: 2013-07-11 22:01    [W:3.322 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site