Messages in this thread | | | Date | Mon, 1 Jul 2013 23:10:03 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v4] tracing/uprobes: Support ftrace_event_file base multibuffer |
| |
On 07/01, Oleg Nesterov wrote: > > On 06/29, zhangwei(Jovi) wrote: > > > > [v3->v4]: > > I am wondering how much you will hate me if I suggest to make v5 ;) > > But look, imho probe_event_enable() looks a bit more confusing than > it needs.
And I am a bit worried this patch removes the is_trace_uprobe_enabled() check from probe_event_enable()...
Yes I think it was never needed, afaics TRACE_REG_*_UNREGISTER can't come without successfull _REGISTER. And the bogus uprobe_unregister() is harmless in this particular case.
So I think this is fine, but perhaps the changelog should mention this "offtopic" change.
Oleg.
| |