Messages in this thread | | | Date | Mon, 1 Jul 2013 18:19:43 +0000 | From | Christoph Lameter <> | Subject | Re: [PATCH] mm, slab: Drop unnecessary slabp->inuse < cachep->num test |
| |
On Tue, 2 Jul 2013, Zhang Yanfei wrote:
> From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> > > In function cache_alloc_refill, we have used BUG_ON to ensure > that slabp->inuse is less than cachep->num before the while > test. And in the while body, we do not change the value of > slabp->inuse and cachep->num, so it is not necessary to test > if slabp->inuse < cachep->num test for every loop.
The body calls slab_get_obj which changes slabp->inuse!
| |